Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong tests for search #4

Open
mesemus opened this issue Nov 28, 2022 · 1 comment
Open

Wrong tests for search #4

mesemus opened this issue Nov 28, 2022 · 1 comment
Assignees
@SilvyPuzzlewell
Labels
backend feat/search tests

Comments

@mesemus
Copy link
Contributor

mesemus commented Nov 28, 2022 •
edited by mirekys
Loading

Tests should use values from sample_metadata_list, not "fish attack painting"

For a generated model with "title: type: fulltext+keyword", the search tests (both resource and service) fail in search.

The generated test should not have the correct alternative hard coded, but should use the value from sample_metadata_list
(and check that the correct number of records is returned, if the value in the list is duplicated)
@mirekys mirekys changed the title Wrong tests - search - should use values from sample_metadata_list, not "fish attack painting" Wrong tests for search Jun 19, 2023
@mesemus
Copy link
Contributor Author

mesemus commented Dec 12, 2023

Also, the paths for the tests should be generated from the model, ignoring non-searchable stuff

mesemus added a commit that referenced this issue Dec 12, 2023
@mesemus
Commenting out search tests - need to rework them - see issue #4
7ca9415
mesemus added a commit that referenced this issue Dec 12, 2023
@mesemus
Merge pull request #23 from oarepo/miroslavsimek/be-219-make-sure-lib…
ed205ba 
…raries-work-with-invenio-rdm-12

Commenting out search tests - need to rework them - see issue #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilvyPuzzlewell SilvyPuzzlewell

Labels
backend feat/search tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mirekys @mesemus @SilvyPuzzlewell