New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to reflect that React Router now supports scroll restoration #521

Open

danielnixon opened this issue Jan 9, 2023 · 1 comment

Member

danielnixon commented Jan 9, 2023

At the time I created this library, React Router (v5? v4?) had no support for scroll restoration. It does now (see https://reactrouter.com/en/6.6.2/start/overview#scroll-restoration).

Does this conflict with what oaf-react-router does? Probably.
Does it support focus restoration as well as scroll position? Probably not.
Do we need to update this library? Probably.
Do we need to update this readme? Definitely.

Member Author

danielnixon commented Jan 11, 2023

See remix-run/react-router#9555

danielnixon mentioned this issue

Support react-router 6.4+ #520

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment