Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use errors instead of panic in dispatching/serialization #25

Open
keks opened this issue Dec 13, 2018 · 0 comments
Open

Use errors instead of panic in dispatching/serialization #25

keks opened this issue Dec 13, 2018 · 0 comments

Comments

@keks
Copy link

keks commented Dec 13, 2018

Functions starting with dispatch don't return an error but fail with panics. These are caught in sendLoop. Using error values would be much more idiomatic go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@keks