-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviewer Nomination: hosea1008 (Li Hongshan) #153
Comments
Li has my support. He's been porting all kinds of changes we made to an internal version of O3DE back to Github and will continue to do so, so it's more than fitting. |
I support this nomination. |
I support the nomination |
I support this nomination |
I support this nomination - the contribution is well proven and ongoing over the past year |
I support this nomination. |
That was pretty quick. @galibzon or @moudgils who can activate the rights for @hosea1008 ? |
@amzn-changml Are you able to resolve this ticket? Thanks. |
Bump |
Hi, can someone take care of this nomination? What should I do next? |
I have pinged @amzn-changml to take a look at this |
@hosea1008 has been granted reviewer status |
Nomination Guidelines
Reviewer Nomination Requirements
6+ contributions successfully submitted to O3DE
https://github.com/o3de/o3de/pulls?q=is%3Apr+author%3Ahosea1008
100+ lines of code changed across all contributions submitted to O3DE
e.g.:
2+ O3DE Reviewers or Maintainers that support promotion from Contributor to Reviewer
I hope to get support from @thefranke and @adiblev.
Requirements to retain the Reviewer role: 4+ Pull Requests reviewed per month
Reviewer/Maintainer Nomination
Fill out the template below including nominee GitHub user name, desired role and personal GitHub profile
I would like to nominate: hosea1008, to become a Reviewer on behalf of sig-graphics-audio. I verify that they have fulfilled the prerequisites for this role.
Reviewers & Maintainers that support this nomination should comment in this issue.
The text was updated successfully, but these errors were encountered: