Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewer Nomination: hosea1008 (Li Hongshan) #153

Open
hosea1008 opened this issue Dec 21, 2023 · 12 comments
Open

Reviewer Nomination: hosea1008 (Li Hongshan) #153

hosea1008 opened this issue Dec 21, 2023 · 12 comments

Comments

@hosea1008
Copy link

hosea1008 commented Dec 21, 2023

Nomination Guidelines

Reviewer Nomination Requirements
6+ contributions successfully submitted to O3DE

https://github.com/o3de/o3de/pulls?q=is%3Apr+author%3Ahosea1008

100+ lines of code changed across all contributions submitted to O3DE

e.g.:

2+ O3DE Reviewers or Maintainers that support promotion from Contributor to Reviewer

I hope to get support from @thefranke and @adiblev.

Requirements to retain the Reviewer role: 4+ Pull Requests reviewed per month


Reviewer/Maintainer Nomination

Fill out the template below including nominee GitHub user name, desired role and personal GitHub profile

I would like to nominate: hosea1008, to become a Reviewer on behalf of sig-graphics-audio. I verify that they have fulfilled the prerequisites for this role.

Reviewers & Maintainers that support this nomination should comment in this issue.

@thefranke
Copy link

Li has my support. He's been porting all kinds of changes we made to an internal version of O3DE back to Github and will continue to do so, so it's more than fitting.

@hosea1008 hosea1008 changed the title Reviewer Nomination: Li Hongshan Reviewer Nomination: hosea1008 (Li Hongshan) Dec 21, 2023
@kh-huawei
Copy link

I support this nomination.

@msat-huawei
Copy link

I support the nomination

@lgleim
Copy link

lgleim commented Dec 21, 2023

I support this nomination

@adiblev
Copy link

adiblev commented Dec 21, 2023

I support this nomination - the contribution is well proven and ongoing over the past year

@galibzon
Copy link
Collaborator

I support this nomination.

@thefranke
Copy link

That was pretty quick. @galibzon or @moudgils who can activate the rights for @hosea1008 ?

@moudgils
Copy link
Contributor

moudgils commented Jan 4, 2024

@amzn-changml Are you able to resolve this ticket? Thanks.

@thefranke
Copy link

Bump

@hosea1008
Copy link
Author

Hi, can someone take care of this nomination? What should I do next?

@moudgils
Copy link
Contributor

moudgils commented Feb 8, 2024

I have pinged @amzn-changml to take a look at this

@amzn-changml
Copy link

@hosea1008 has been granted reviewer status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants