-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed RFC Feature : Bloom Mask #125
Comments
Approved. This is a welcome feature, but the |
As a floating point number, bloomMask can strengthen or weaken the bloom strength of a single object, for example, 0.5x or 2x. If it's a boolean value, the user can only turn on/off, which reduces the capability of the feature, so the bloomMask is not considered a boolean shader option. |
Since this RFC is accepted please open a PR and move this RFC to this folder - https://github.com/o3de/sig-graphics-audio/tree/main/rfcs where we will track all the new RFCs. Thanks. |
Summary:
This proposal outlines an extended ability to control the bloom effect on an object-by-object basis in StandardPBR materialtype.
What is the relevance of this feature?
Why is this important? What are the use cases? What will it do once completed?
Feature design description:
This design is mainly divided into two parts: bloom pass and wind bloomMask implementation in StandardPBR materialtype.
Design of the bloom pass:
I added two subpasses to the bloom pass to generate the mask texture and blend the scene colors. And bloomMask Pass outputs the mask texture in response to the BloomMask attribute in MaterialSrg.
Design of the bloomMask for bloom in StandardPBR materialtype:
This attribute is a floating-point value that enhances/degrades its own bloom effect.
Other settings
Added global switches and material lua scripts to optimize performance.
Result
Technical design description:
One of the important things is the modification of bloompass.
Since most objects don't use this feature, you can turn off their shader.
What are the advantages of the feature?
Precise control of bloom effects on an object-by-object basis
In addition, we can enable or disable this feature conveniently without causing other impacts..
What are the disadvantages of the feature?
This feature adds some performance and memory overhead.
How will users learn this feature?
users only need to add the Bloom component and adjust the bloomMask attribute of the material panel.
Are there any open questions?
The text was updated successfully, but these errors were encountered: