Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 Robot Importer missing meshes in some URDFs #475

Open
michalpelka opened this issue Aug 28, 2023 · 2 comments
Open

ROS2 Robot Importer missing meshes in some URDFs #475

michalpelka opened this issue Aug 28, 2023 · 2 comments
Labels
feature/robotics This item is related to robotics. kind/bug Categorizes issue or PR as related to a bug. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation

Comments

@michalpelka
Copy link
Contributor

I've tried to import Panda Franka from Moveit2 resources. I've changed the URDF adding intertia to all links:
https://gist.github.com/michalpelka/aed725c3f87e01b7ee02c7ef23d84477

Unfortunately URDF is loaded, but without any meshes. I've added print statement to link visitor:

        const auto processLink = [&addFilenameFromGeometry, visual, colliders](const sdf::Link* link)
        {
           AZ_Printf("ProcessLink", "link %s, visuals : %d, collisions : %d\n", link->Name().c_str(), link->VisualCount(), link->CollisionCount());

This visitor produces ouput:


<13:40:25> (ProcessLink) - link panda_link0, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_link1, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_link2, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_link3, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_link4, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_link5, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_link6, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_link7, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_link8, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_hand, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_leftfinger, visuals : 0, collisions : 0

<13:40:25> (ProcessLink) - link panda_rightfinger, visuals : 0, collisions : 0
@michalpelka michalpelka added kind/bug Categorizes issue or PR as related to a bug. priority/critical Critical priority. Must be actively worked on as someone's top priority right now. feature/robotics This item is related to robotics. labels Aug 28, 2023
@michalpelka
Copy link
Contributor Author

michalpelka commented Aug 28, 2023

Interestingly, after adjusting the file to have an inertia matrix 😲 libSDF started to report visual meshes.
Here is the modified URDF:
https://gist.github.com/michalpelka/50726337ed1b6d073fa4d8915d9a88a8
It is clearly bug in libsdf.

@michalpelka michalpelka added priority/major Major priority. Work that should be handled after all blocking and critical work is done. and removed priority/critical Critical priority. Must be actively worked on as someone's top priority right now. labels Aug 28, 2023
@jhanca-robotecai
Copy link
Contributor

Interestingly, after adjusting the file to have an inertia matrix 😲 libSDF started to report visual meshes.
Here is the modified URDF:
https://gist.github.com/michalpelka/50726337ed1b6d073fa4d8915d9a88a8
It is clearly bug in libsdf.

If inertial tag is available, inertia matrix is required .

It should be checked why we do not get any notification about the problem. When I try to load the model with a sample libsdfrotmat app, I get the error message:

Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link0]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link1]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link2]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link3]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link4]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link5]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link6]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link7]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_link8]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_hand]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_leftfinger]
Error:   Inertial element must have inertia element
Error:   Could not parse inertial element for Link [panda_rightfinger]

@byrcolin byrcolin added the sig/simulation Categorizes an issue or PR as relevant to SIG Simulation label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/robotics This item is related to robotics. kind/bug Categorizes issue or PR as related to a bug. priority/major Major priority. Work that should be handled after all blocking and critical work is done. sig/simulation Categorizes an issue or PR as relevant to SIG Simulation
Projects
None yet
Development

No branches or pull requests

3 participants