-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For dcn model #6
Comments
The x_l's size should be batch_size * [field_size * embedding_size],in DCN paper,x_l's size should be [filed_sizeembedding], so result of x_0x_l^T is rank-one. Thinking of expanding to batch_size [field_sizeembedding_size], the result's size should be batch_size1. If use torch.matmul(x_0, x_l.t()), the size is wrong. |
The shapes of I am not familiar with pytorch, but in mxnet I use |
@jiarenyf The x_0 in my code is two-dimension . And I do the same thing as batch_dot in my code |
But the result of |
In
dnn_ctr/model/DCN.py
Line 232 in c750fec
x_0 * x_l
should be replaced bytorch.matmul(x_0, x_l.t())
, right ?The text was updated successfully, but these errors were encountered: