Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twig loop executes much more slowly without any output #4

Closed
mark-adigital opened this issue Jun 8, 2018 · 2 comments
Closed

Twig loop executes much more slowly without any output #4

mark-adigital opened this issue Jun 8, 2018 · 2 comments

Comments

@mark-adigital
Copy link

Hi,

I have observed an issue whereby performance suffers greatly when minify tags contain a Twig loop that doesn't have any output. Adding an empty <span> tag to the loop eliminates the issue and the loop is performing several conditionals.

Thanks,

Mark

@khalwat
Copy link
Contributor

khalwat commented Jul 21, 2018

hrm. I'm not sure if there's much I could do about this, it's probably an issue with the core Minify:

https://github.com/mrclay/minify

I could preflight it, but that'd just be paving over the problem.

@mark-adigital
Copy link
Author

Ok, thanks for looking into it. I've raised an issue in the core library now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants