All ModbusTCP plugins don't update to a changed IP on the fly

[mzanetti]

None of the ModbusTCP generator based plugins handle the case that a device changes IP address on the fly. They will stay disconnected until nymea is restarted.

[t-mon]

Also where the monitor has been introduced already?

[mzanetti]

Yes. Phoneixconnect seems to be the only one that is fixed already.

[mzanetti]

The reason is that the generated ModbusTcpConnection classes take the IP in the ctor, so it's only set at startup. Anyhow, luckily the base class has a setAddress() method. It seems to be enough to connect the monitors networkInfoChanged signal to that one (and the already existing reconnect timer will then take care about calling connectToHost() again).

[t-mon]

https://github.com/nymea/nymea-plugins-modbus/blob/master/libnymea-modbus/modbustcpmaster.cpp#L119

If reachable changes in the monitor, i perform a reconnect after setting the IP in the base class, which triggers the connectDevice() method where all properties get updated before actually performing the connection.

For example: https://github.com/nymea/nymea-plugins-modbus/blob/master/kostal/integrationpluginkostal.cpp#L322

Not getting what the phoenix connect is doing different?

[mzanetti]

ok. right. fine for Kostal. Seems to be missing in alphainnotec and stiebeleltron now only....

[t-mon]

yeah, we cannot test those currently...