Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support disabling sonarr or radarr #124

Open
glensc opened this issue Apr 7, 2024 · 2 comments
Open

Add support disabling sonarr or radarr #124

glensc opened this issue Apr 7, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@glensc
Copy link
Collaborator

glensc commented Apr 7, 2024

Partially due #108, i'm not interested of allowing fulfilling sonarr requests at this time. but doesn't seem to be possible to disable sonarr integration, it can result just app startup failure if I fill bogus URL there: #120

perhaps: enabled: true option to config?

@nylonee nylonee added the enhancement New feature or request label Apr 8, 2024
@nylonee
Copy link
Owner

nylonee commented Apr 8, 2024

Yes this hasn't been added yet, I've been thinking about this, implementing this config would be the first step in a few other features as well:

  • Allowing multiple Sonarr/Radarr instances (no idea why somebody would want this though)
  • Allowing other 'extensions' e.g. Syncing Plex watchlist status to Trakt and not needing the Sonarr/Radarr integration

It's not as simple as adding a config to disable the feature, because right now Configuration expects configuration for Sonarr/Radarr, and will fail if it's not provided.

The best way to implement this would be to set:

                          sonarrConfiguration: SonarrConfiguration,
                          radarrConfiguration: RadarrConfiguration,

to:

                          sonarrConfiguration: Option[SonarrConfiguration],
                          radarrConfiguration: Option[RadarrConfiguration],

This will fail the compiler (in Scala this is what we want). Going one by one through all the compiler errors will ensure that we've correctly implemented this due to the strong type safety.

@nylonee nylonee added the good first issue Good for newcomers label Apr 11, 2024
@ZDTaylor
Copy link

ZDTaylor commented Apr 22, 2024

I was going to open a separate issue (and still can if desired), but I think it makes sense to bring up here:

I'm one of the people that would love to be able to push requests to multiple instances of radarr/sonarr. I have separate HD/4K/DV instances for each *arr. Right now, I'm:

  1. Syncing Plex watchlists to overseerr with auto-request/auto-approve
  2. Overseerr pushes the request to the HD instance
  3. The 4K/DV instances use list syncs to grab the requests from the HD instance every 5/15 minutes (time not configurable).

If watchlistarr could push to multiple instances, it would basically eliminate all the unnecessary lead time in my set up.

I decided to post on this issue because I think refactoring the config to use a list of radar/sonarr instances would solve both problems since you could just leave either list empty to disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants