From a0a6fef92b12791bdbb9e026e9aeee7e5f5d327d Mon Sep 17 00:00:00 2001 From: Andrew Dickinson Date: Tue, 2 Apr 2024 19:25:28 -0400 Subject: [PATCH] Import phone numbers from dupes when we don't already have one (#306) --- src/meshdb/utils/spreadsheet_import/parse_member.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/meshdb/utils/spreadsheet_import/parse_member.py b/src/meshdb/utils/spreadsheet_import/parse_member.py index 34f6172f..c679a1b9 100644 --- a/src/meshdb/utils/spreadsheet_import/parse_member.py +++ b/src/meshdb/utils/spreadsheet_import/parse_member.py @@ -121,14 +121,18 @@ def diff_new_member_against_existing( ) diff_notes += f"\nDropped name change from install #{row_id}: {new_member.name}" - if existing_member.phone_number != new_member.phone_number and new_member.phone_number: + if ( + existing_member.phone_number != new_member.phone_number + and new_member.phone_number + and existing_member.phone_number + ): add_dropped_edit( DroppedModification( list(install.install_number for install in existing_member.installs.all()), row_id, existing_member.primary_email_address, "member.phone_number", - existing_member.phone_number if existing_member.phone_number else "", + existing_member.phone_number, new_member.phone_number, ) ) @@ -228,6 +232,9 @@ def nop(*args, **kwargs): add_dropped_edit, ) + if formatted_phone_number and not existing_members[0].phone_number: + existing_members[0].phone_number = formatted_phone_number + # TODO: Don't forget to remove me if we remove the previous use of contact notes above if row.contactNotes: if not existing_members[0].notes: