Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has_attachment rule #686

Open
ericnewcomer opened this issue May 26, 2019 · 1 comment
Open

Add has_attachment rule #686

ericnewcomer opened this issue May 26, 2019 · 1 comment

Comments

@ericnewcomer
Copy link
Member

I think we have discussed this in the past and apparently not implemented it or recorded that decision, so putting it here.

This is coming from a customer who is trying to route on if the contact uploaded a file. In the past we've forced a text match for /^http.*$/ or somesuch, but believe we were moving away from a text filled with url data at some point.

@rowanseymour
Copy link
Member

rowanseymour commented May 27, 2019

Ok my recollection (since we suck at taking notes in our discussions!) is that we initially decided we would have a has_attachment rule... and its operand should be @input.attachments.. but that would mean that for it to sit in the same switch router as other messagey tests.. we'd need tests to have different operands instead of the idea of a 1 operand -> N cases. We tried that.. and then abandoned it. I think rightly so because it was getting complicated quickly.

So we still need to figure out where such a has_attachment rule would live. Is it on its own router with different test options like has_image, has audio etc, or do we try again to find a way for it to live on the same router as the regular 'wait for message' tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants