Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace max_value_length on env with new engine options for max field and result chars #1175

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

rowanseymour
Copy link
Member

Should never have been an env setting because it's engine level

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1175 (44e3bed) into main (66d4bb2) will increase coverage by 0.01%.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   87.80%   87.81%   +0.01%     
==========================================
  Files         258      258              
  Lines       10943    10944       +1     
==========================================
+ Hits         9608     9611       +3     
+ Misses        917      915       -2     
  Partials      418      418              
Files Changed Coverage Δ
envs/environment.go 96.92% <ø> (-0.27%) ⬇️
flows/modifiers/channel.go 91.66% <ø> (ø)
flows/modifiers/groups.go 96.07% <ø> (ø)
flows/modifiers/language.go 100.00% <ø> (ø)
flows/modifiers/status.go 100.00% <ø> (ø)
flows/modifiers/timezone.go 83.33% <ø> (ø)
flows/modifiers/urn.go 100.00% <ø> (ø)
flows/modifiers/urns.go 100.00% <ø> (ø)
flows/engine/session.go 74.29% <50.00%> (ø)
flows/actions/base.go 91.13% <100.00%> (+0.05%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour rowanseymour merged commit ae541a6 into main Aug 15, 2023
7 checks passed
@rowanseymour rowanseymour deleted the max_field_and_result branch August 15, 2023 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant