Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic get/put operations to dynamo service #143

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Sep 16, 2024

Also tweak .Test() to be a list tables operation instead of a describe table, because it gets used in tests where the table might not exist yet.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 65.95745% with 16 lines in your changes missing coverage. Please review.

Project coverage is 90.55%. Comparing base (2d72c4b) to head (955c31f).

Files with missing lines Patch % Lines
aws/dynamo/marshal.go 66.66% 5 Missing and 3 partials ⚠️
aws/dynamo/service.go 65.21% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   91.34%   90.55%   -0.80%     
==========================================
  Files          47       48       +1     
  Lines        1734     1779      +45     
==========================================
+ Hits         1584     1611      +27     
- Misses        105      115      +10     
- Partials       45       53       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 710045b into main Sep 16, 2024
5 of 7 checks passed
@rowanseymour rowanseymour deleted the dynamo_get_put branch September 16, 2024 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant