Pass in separate NW.js executable path #2
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Scenario
For apps manually "auto-updating":
nw.App.dataPath + '/v2'
0.30.0
on launch, but the v1 code's splash screen always checks to see if there are newer versionschild_process
instead ofnw.Window.open
Questions:
child_process
method should be used for this (exec, spawn, fork, etc.)Answers:
From: Brian Bothwell (@sysrage in Gitter chat)
Acceptance Criteria:
README.md
to include an optional String calledexecutablePath
and a description of:url
andnewWindowOptions
params are ignored if theexecutablePath
exists, otherwise are used as fallbacks if the executable cannot be found. If executable not found, nw-splasher will attempt to launch the window from the current NW.js executable in a separate process (as ifexecutablePath
was not used).executablePath
is truthy but not a string. Also warn ifexecutablePath
is a string, but the file does not exist on the system. (pull infs-extra
for saferexistsSync
check).package.json
and follow it's window instructions.show: false
, and it'smain
also uses thenw-splasher
library, and it communicates on the same web socket port, callingnwSplasher.closeSplashAndShowApp()
, then the splash screen executable should completely close and not be found in the system's Task Manager while the new window is still running.The text was updated successfully, but these errors were encountered: