fix(dap): Flutter/Dart project detection improvement #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-salman-a
force-pushed
the
flutter_dart_detection_improvement
branch
from
3aa0e51 to
7388b8a
Compare
sidlatau
reviewed
Dec 16, 2023
| local is_flutter_project = vim.loop.fs_stat(path.join(root_dir, ".metadata")) | ||
| local function search_pubspec_for_flutter_sdk() | ||
| local pubspec_path = path.join(root_dir, "pubspec.yaml") | ||
| return pcall(vim.cmd, "silent 1vimgrep! /sdk:\\_s\\+flutter\\C/j" .. pubspec_path) |
There was a problem hiding this comment.
For the reference, I see Dart-Code uses a similar approach, it parses yaml and checks dependencies:
https://github.com/Dart-Code/Dart-Code/blob/0f3afe552c2cd918b0031fc1b77ede100b3fbea8/src/shared/utils/fs.ts#L163C11-L176
So I think this approach is valid, but I just do not fully understand regex: is underscore needed in '\_s\'?
|
PR with almost the same logic was merged (#326) so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #282 by searching for the flutter sdk dependency from the
pubspec.yamlfile located in the root directory. This is based on the fact that thepubspec.yamlin all flutter projects requires the flutter sdk dependency, as stated by this specification.This is the simplest way that I can think of to differentiate between flutter or dart project, but any other suggestions are welcome 😀.
EDIT: This is still not a perfect solution as this still doesn't account for any comments that can be provided in the yaml file, but I think with this change and keeping the old behavior should be good enough for most users.