Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: libmrc_pymrc.so installed twice #428

Closed
2 tasks done
dagardner-nv opened this issue Dec 27, 2023 · 0 comments · Fixed by #429
Closed
2 tasks done

[BUG]: libmrc_pymrc.so installed twice #428

dagardner-nv opened this issue Dec 27, 2023 · 0 comments · Fixed by #429
Assignees
@dagardner-nv
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

24.03

Which installation method(s) does this occur on?

Conda

Describe the bug.

When MRC is installed as a conda package, libmrc_pymrc.so is installed in two locations:

  • ${CONDA_PREFIX}/lib <-- this is the one actually used
  • ${CONDA_PREFIX}/lib/python3.10/site-packages/mrc/_pymrc/libmrc_pymrc.so

Minimum reproducible example

No response

Relevant log output

No response

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow MRC's Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@dagardner-nv dagardner-nv added the bug Something isn't working label Dec 27, 2023
@dagardner-nv dagardner-nv self-assigned this Dec 27, 2023
@dagardner-nv dagardner-nv mentioned this issue Dec 27, 2023
Merged
3 tasks
@rapids-bot rapids-bot bot closed this as completed in #429 Jan 5, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Morpheus Boards Jan 5, 2024
rapids-bot bot pushed a commit that referenced this issue Jan 5, 2024
@dagardner-nv
Remove redundant copy of libmrc_pymrc.so (#429)
294e087 
* Prevent `libmrc_pymrc.so` from being installed into python's site-packages dir, as this lib is already present in the lib dir.
* Fixes permissions issue where the conda env was owned by `root:root`, simply ensuring the env retains the `conda` group permission wasn't sufficient as `cmake` attempts to modify exiting dirs (https://gitlab.kitware.com/cmake/cmake/-/issues/10978), and running `chmod -R` after the fact is too slow.

Closes #428

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant copy of libmrc_pymrc.so dagardner-nv/MRC
1 participant
@dagardner-nv