From e03db964075f9a058c029c641c5ae36cd1b9bb55 Mon Sep 17 00:00:00 2001
From: Christophe Carvalho Vilas-Boas <christophe.carvalhovilasboas@gmail.com>
Date: Sat, 23 Nov 2024 18:04:38 +0100
Subject: [PATCH 1/5] feat(types): Strapi v5 types for Sort & Populate params

---
 playground/nuxt.config.ts               |  2 +-
 playground/pages/index.vue              | 29 +++++++++++++++++++++++++
 src/runtime/composables-v5/useStrapi.ts | 20 ++++++++---------
 src/runtime/types/v5.ts                 | 19 +++++++++++-----
 4 files changed, 54 insertions(+), 16 deletions(-)

diff --git a/playground/nuxt.config.ts b/playground/nuxt.config.ts
index c89af3ab..c9998906 100644
--- a/playground/nuxt.config.ts
+++ b/playground/nuxt.config.ts
@@ -14,7 +14,7 @@ export default defineNuxtConfig({
   // },
 
   strapi: {
-    version: 'v3',
+    version: 'v5',
     url: 'http://localhost:1337'
     // To enable the devtools, read https://strapi.nuxtjs.org/devtools
     // devtools: true
diff --git a/playground/pages/index.vue b/playground/pages/index.vue
index 5f659d6f..8f05e55b 100644
--- a/playground/pages/index.vue
+++ b/playground/pages/index.vue
@@ -52,6 +52,7 @@
 </template>
 
 <script lang="ts" setup>
+const strapi = useStrapi()
 const user = useStrapiUser()
 const url = useStrapiUrl()
 const version = useStrapiVersion()
@@ -60,6 +61,34 @@ const { login, logout, getProviderAuthenticationUrl } = useStrapiAuth()
 const loading = ref(false)
 const form = reactive({ identifier: '', password: '' })
 
+type Collection = {
+  firstname: string
+  lastname: string
+  relation: {
+    name: string
+    nestedRelation: {
+      name: string
+      arr: Array<{ name: string }>
+    }
+  }
+}
+
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+const getCollections = () => {
+  return strapi.find<Collection>('collection', {
+    sort: ['lastname:asc', 'firstname'],
+    populate: 'relation.nestedRelation.arr'
+  })
+}
+
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+const getUntyped = () => {
+  return strapi.find('untyped', {
+    sort: ['random'],
+    populate: 'relationRandom'
+  })
+}
+
 const onSubmit = async () => {
   loading.value = true
 
diff --git a/src/runtime/composables-v5/useStrapi.ts b/src/runtime/composables-v5/useStrapi.ts
index 12a8ca9e..f1c75d84 100644
--- a/src/runtime/composables-v5/useStrapi.ts
+++ b/src/runtime/composables-v5/useStrapi.ts
@@ -3,8 +3,8 @@ import type { Strapi5ResponseSingle, Strapi5RequestParams, Strapi5ResponseMany }
 import { useStrapiClient } from '#imports'
 
 interface StrapiV5Client<T> {
-  find<F = T>(contentType: string, params?: Strapi5RequestParams): Promise<Strapi5ResponseMany<F>>
-  findOne<F = T>(contentType: string, documentId?: string | Strapi5RequestParams, params?: Strapi5RequestParams): Promise<Strapi5ResponseSingle<F>>
+  find<F = T>(contentType: string, params?: Strapi5RequestParams<F>): Promise<Strapi5ResponseMany<F>>
+  findOne<F = T>(contentType: string, documentId?: string | Strapi5RequestParams<F>, params?: Strapi5RequestParams<F>): Promise<Strapi5ResponseSingle<F>>
   create<F = T>(contentType: string, data: Partial<F>): Promise<Strapi5ResponseSingle<F>>
   update<F = T>(contentType: string, documentId: string | Partial<F>, data?: Partial<F>): Promise<Strapi5ResponseSingle<F>>
   delete<F = T>(contentType: string, documentId?: string): Promise<Strapi5ResponseSingle<F>>
@@ -17,10 +17,10 @@ export const useStrapi = <T>(): StrapiV5Client<T> => {
    * Get a list of {content-type} entries
    *
    * @param  {string} contentType - Content type's name pluralized
-   * @param  {Strapi5RequestParams} [params] - Query parameters
+   * @param  {Strapi5RequestParams<T>} [params] - Query parameters
    * @returns Promise<T>
    */
-  const find = <T>(contentType: string, params?: Strapi5RequestParams, fetchOptions?: FetchOptions): Promise<Strapi5ResponseMany<T>> => {
+  const find = <T>(contentType: string, params?: Strapi5RequestParams<T>, fetchOptions?: FetchOptions): Promise<Strapi5ResponseMany<T>> => {
     return client(`/${contentType}`, { method: 'GET', params, ...fetchOptions })
   }
 
@@ -29,10 +29,10 @@ export const useStrapi = <T>(): StrapiV5Client<T> => {
    *
    * @param  {string} contentType - Content type's name pluralized
    * @param  {string} documentId - ID of entry
-   * @param  {Strapi5RequestParams} [params] - Query parameters
+   * @param  {Strapi5RequestParams<T>} [params] - Query parameters
    * @returns Promise<T>
    */
-  const findOne = <T>(contentType: string, documentId?: string | Strapi5RequestParams, params?: Strapi5RequestParams, fetchOptions?: FetchOptions): Promise<Strapi5ResponseSingle<T>> => {
+  const findOne = <T>(contentType: string, documentId?: string | Strapi5RequestParams<T>, params?: Strapi5RequestParams<T>, fetchOptions?: FetchOptions): Promise<Strapi5ResponseSingle<T>> => {
     if (typeof documentId === 'object') {
       params = documentId
       documentId = undefined
@@ -48,10 +48,10 @@ export const useStrapi = <T>(): StrapiV5Client<T> => {
    *
    * @param  {string} contentType - Content type's name pluralized
    * @param  {Record<string, any>} data - Form data
-   * @param  {Strapi5RequestParams} [params] - Query parameters
+   * @param  {Strapi5RequestParams<T>} [params] - Query parameters
    * @returns Promise<T>
    */
-  const create = <T>(contentType: string, data: Partial<T>, params: Strapi5RequestParams = {}): Promise<Strapi5ResponseSingle<T>> => {
+  const create = <T>(contentType: string, data: Partial<T>, params: Strapi5RequestParams<T> = {}): Promise<Strapi5ResponseSingle<T>> => {
     return client(`/${contentType}`, { method: 'POST', body: { data }, params })
   }
 
@@ -61,10 +61,10 @@ export const useStrapi = <T>(): StrapiV5Client<T> => {
    * @param  {string} contentType - Content type's name pluralized
    * @param  {string} documentId - ID of entry to be updated
    * @param  {Record<string, any>} data - Form data
-   * @param  {Strapi5RequestParams} [params] - Query parameters
+   * @param  {Strapi5RequestParams<T>} [params] - Query parameters
    * @returns Promise<T>
    */
-  const update = <T>(contentType: string, documentId: string | Partial<T>, data?: Partial<T>, params: Strapi5RequestParams = {}): Promise<Strapi5ResponseSingle<T>> => {
+  const update = <T>(contentType: string, documentId: string | Partial<T>, data?: Partial<T>, params: Strapi5RequestParams<T> = {}): Promise<Strapi5ResponseSingle<T>> => {
     if (typeof documentId === 'object') {
       data = documentId
       documentId = undefined
diff --git a/src/runtime/types/v5.ts b/src/runtime/types/v5.ts
index 2b87629e..718302f3 100644
--- a/src/runtime/types/v5.ts
+++ b/src/runtime/types/v5.ts
@@ -9,12 +9,21 @@ export interface Strapi5Error {
   }
 }
 
-export interface Strapi5RequestParams {
-  fields?: Array<string>
-  populate?: string | Array<string> | object
-  sort?: string | Array<string>
+type Strapi5RequestParamSort<T> = `${Exclude<keyof T, symbol>}${':asc' | ':desc' | ''}`
+type Strapi5RequestParamPopulate<T> = {
+  [K in keyof T]: T[K] extends object
+    ? T[K] extends Array<infer I>
+      ? `${Exclude<K, symbol>}` | `${Exclude<K, symbol>}.${Strapi5RequestParamPopulate<I>}`
+      : `${Exclude<K, symbol>}` | `${Exclude<K, symbol>}.${Strapi5RequestParamPopulate<T[K]>}`
+    : never;
+}[keyof T]
+
+export interface Strapi5RequestParams<T> {
+  fields?: Array<keyof T>
+  populate?: '*' | Strapi5RequestParamPopulate<T> | Array<Strapi5RequestParamPopulate<T>>
+  sort?: Strapi5RequestParamSort<T> | Array<Strapi5RequestParamSort<T>>
   pagination?: PaginationByOffset | PaginationByPage
-  filters?: Record<string, unknown>
+  filters?: Record<keyof T, unknown>
   publicationState?: 'live' | 'preview'
   locale?: StrapiLocale | null
 }

From 684d27a8ec16bdbccfda873194aebb54f82f9940 Mon Sep 17 00:00:00 2001
From: Christophe Carvalho Vilas-Boas <christophe.carvalhovilasboas@gmail.com>
Date: Sat, 23 Nov 2024 18:09:21 +0100
Subject: [PATCH 2/5] fix(types): Revert Strapi5RequestParams.filters type

---
 src/runtime/types/v5.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/runtime/types/v5.ts b/src/runtime/types/v5.ts
index 718302f3..da6ed2f6 100644
--- a/src/runtime/types/v5.ts
+++ b/src/runtime/types/v5.ts
@@ -23,7 +23,7 @@ export interface Strapi5RequestParams<T> {
   populate?: '*' | Strapi5RequestParamPopulate<T> | Array<Strapi5RequestParamPopulate<T>>
   sort?: Strapi5RequestParamSort<T> | Array<Strapi5RequestParamSort<T>>
   pagination?: PaginationByOffset | PaginationByPage
-  filters?: Record<keyof T, unknown>
+  filters?: Record<string, unknown>
   publicationState?: 'live' | 'preview'
   locale?: StrapiLocale | null
 }

From 65630060bcd8ffc5b85d3f75b2a5eb75d98ae7bf Mon Sep 17 00:00:00 2001
From: Christophe Carvalho Vilas-Boas <christophe.carvalhovilasboas@gmail.com>
Date: Sat, 23 Nov 2024 18:13:49 +0100
Subject: [PATCH 3/5] feat(types): Strapi v5 types for Fields param

---
 playground/pages/index.vue | 1 +
 src/runtime/types/v5.ts    | 9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/playground/pages/index.vue b/playground/pages/index.vue
index 8f05e55b..d3e39a9d 100644
--- a/playground/pages/index.vue
+++ b/playground/pages/index.vue
@@ -76,6 +76,7 @@ type Collection = {
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 const getCollections = () => {
   return strapi.find<Collection>('collection', {
+    fields: ['firstname'],
     sort: ['lastname:asc', 'firstname'],
     populate: 'relation.nestedRelation.arr'
   })
diff --git a/src/runtime/types/v5.ts b/src/runtime/types/v5.ts
index da6ed2f6..3959d45c 100644
--- a/src/runtime/types/v5.ts
+++ b/src/runtime/types/v5.ts
@@ -9,7 +9,14 @@ export interface Strapi5Error {
   }
 }
 
+type Strapi5RequestParamField<T> = {
+  [K in keyof T]: T[K] extends object
+    ? never
+    : K;
+}[keyof T]
+
 type Strapi5RequestParamSort<T> = `${Exclude<keyof T, symbol>}${':asc' | ':desc' | ''}`
+
 type Strapi5RequestParamPopulate<T> = {
   [K in keyof T]: T[K] extends object
     ? T[K] extends Array<infer I>
@@ -19,7 +26,7 @@ type Strapi5RequestParamPopulate<T> = {
 }[keyof T]
 
 export interface Strapi5RequestParams<T> {
-  fields?: Array<keyof T>
+  fields?: Array<Strapi5RequestParamField<T>>
   populate?: '*' | Strapi5RequestParamPopulate<T> | Array<Strapi5RequestParamPopulate<T>>
   sort?: Strapi5RequestParamSort<T> | Array<Strapi5RequestParamSort<T>>
   pagination?: PaginationByOffset | PaginationByPage

From b32d7154a9a258086ef59a79266956912e1dc4e3 Mon Sep 17 00:00:00 2001
From: Christophe Carvalho Vilas-Boas <christophe.carvalhovilasboas@gmail.com>
Date: Sun, 24 Nov 2024 12:30:22 +0100
Subject: [PATCH 4/5] feat(types): Improve RequestParams for v4

---
 src/runtime/composables-v4/useStrapi.ts |  8 ++++----
 src/runtime/types/index.ts              | 16 ++++++++++++++++
 src/runtime/types/v4.ts                 | 10 +++++-----
 src/runtime/types/v5.ts                 | 24 ++++--------------------
 4 files changed, 29 insertions(+), 29 deletions(-)

diff --git a/src/runtime/composables-v4/useStrapi.ts b/src/runtime/composables-v4/useStrapi.ts
index 50c6767c..5b41c7b1 100644
--- a/src/runtime/composables-v4/useStrapi.ts
+++ b/src/runtime/composables-v4/useStrapi.ts
@@ -3,8 +3,8 @@ import type { Strapi4ResponseSingle, Strapi4RequestParams, Strapi4ResponseMany }
 import { useStrapiClient } from '#imports'
 
 interface StrapiV4Client<T> {
-  find<F = T>(contentType: string, params?: Strapi4RequestParams): Promise<Strapi4ResponseMany<F>>
-  findOne<F = T>(contentType: string, id?: string | number | Strapi4RequestParams, params?: Strapi4RequestParams): Promise<Strapi4ResponseSingle<F>>
+  find<F = T>(contentType: string, params?: Strapi4RequestParams<F>): Promise<Strapi4ResponseMany<F>>
+  findOne<F = T>(contentType: string, id?: string | number | Strapi4RequestParams<F>, params?: Strapi4RequestParams<F>): Promise<Strapi4ResponseSingle<F>>
   create<F = T>(contentType: string, data: Partial<F>): Promise<Strapi4ResponseSingle<F>>
   update<F = T>(contentType: string, id: string | number | Partial<F>, data?: Partial<F>): Promise<Strapi4ResponseSingle<F>>
   delete<F = T>(contentType: string, id?: string | number): Promise<Strapi4ResponseSingle<F>>
@@ -20,7 +20,7 @@ export const useStrapi = <T>(): StrapiV4Client<T> => {
    * @param  {Strapi4RequestParams} [params] - Query parameters
    * @returns Promise<T>
    */
-  const find = <T>(contentType: string, params?: Strapi4RequestParams, fetchOptions?: FetchOptions): Promise<Strapi4ResponseMany<T>> => {
+  const find = <T>(contentType: string, params?: Strapi4RequestParams<T>, fetchOptions?: FetchOptions): Promise<Strapi4ResponseMany<T>> => {
     return client(`/${contentType}`, { method: 'GET', params, ...fetchOptions })
   }
 
@@ -32,7 +32,7 @@ export const useStrapi = <T>(): StrapiV4Client<T> => {
    * @param  {Strapi4RequestParams} [params] - Query parameters
    * @returns Promise<T>
    */
-  const findOne = <T>(contentType: string, id?: string | number | Strapi4RequestParams, params?: Strapi4RequestParams, fetchOptions?: FetchOptions): Promise<Strapi4ResponseSingle<T>> => {
+  const findOne = <T>(contentType: string, id?: string | number | Strapi4RequestParams<T>, params?: Strapi4RequestParams<T>, fetchOptions?: FetchOptions): Promise<Strapi4ResponseSingle<T>> => {
     if (typeof id === 'object') {
       params = id
       id = undefined
diff --git a/src/runtime/types/index.ts b/src/runtime/types/index.ts
index 57a49876..cea49a97 100644
--- a/src/runtime/types/index.ts
+++ b/src/runtime/types/index.ts
@@ -570,6 +570,22 @@ export interface StrapiGraphqlVariables {
   [variable: string]: unknown
 }
 
+export type StrapiRequestParamField<T> = {
+  [K in keyof T]: T[K] extends object
+    ? never
+    : K;
+}[keyof T]
+
+export type StrapiRequestParamSort<T> = `${Exclude<keyof T, symbol>}${':asc' | ':desc' | ''}`
+
+export type StrapiRequestParamPopulate<T> = {
+  [K in keyof T]: T[K] extends object
+    ? T[K] extends Array<infer I>
+      ? `${Exclude<K, symbol>}` | `${Exclude<K, symbol>}.${StrapiRequestParamPopulate<I>}`
+      : `${Exclude<K, symbol>}` | `${Exclude<K, symbol>}.${StrapiRequestParamPopulate<T[K]>}`
+    : never;
+}[keyof T]
+
 export * from './v3'
 export * from './v4'
 export * from './v5'
diff --git a/src/runtime/types/v4.ts b/src/runtime/types/v4.ts
index 4a7864ac..b3ce7c31 100644
--- a/src/runtime/types/v4.ts
+++ b/src/runtime/types/v4.ts
@@ -1,4 +1,4 @@
-import type { StrapiLocale } from '.'
+import type { StrapiLocale, StrapiRequestParamField, StrapiRequestParamPopulate, StrapiRequestParamSort } from '.'
 
 export interface Strapi4Error {
   error: {
@@ -21,10 +21,10 @@ export interface PaginationByOffset {
   withCount?: boolean
 }
 
-export interface Strapi4RequestParams {
-  fields?: Array<string>
-  populate?: string | Array<string> | object
-  sort?: string | Array<string>
+export interface Strapi4RequestParams<T> {
+  fields?: Array<StrapiRequestParamField<T>>
+  populate?: '*' | StrapiRequestParamPopulate<T> | Array<StrapiRequestParamPopulate<T>>
+  sort?: StrapiRequestParamSort<T> | Array<StrapiRequestParamSort<T>>
   pagination?: PaginationByOffset | PaginationByPage
   filters?: Record<string, unknown>
   publicationState?: 'live' | 'preview'
diff --git a/src/runtime/types/v5.ts b/src/runtime/types/v5.ts
index 3959d45c..5599bfcc 100644
--- a/src/runtime/types/v5.ts
+++ b/src/runtime/types/v5.ts
@@ -1,4 +1,4 @@
-import type { MetaResponsePaginationByOffset, MetaResponsePaginationByPage, PaginationByOffset, PaginationByPage, StrapiLocale } from '.'
+import type { MetaResponsePaginationByOffset, MetaResponsePaginationByPage, PaginationByOffset, PaginationByPage, StrapiLocale, StrapiRequestParamField, StrapiRequestParamPopulate, StrapiRequestParamSort } from '.'
 
 export interface Strapi5Error {
   error: {
@@ -9,26 +9,10 @@ export interface Strapi5Error {
   }
 }
 
-type Strapi5RequestParamField<T> = {
-  [K in keyof T]: T[K] extends object
-    ? never
-    : K;
-}[keyof T]
-
-type Strapi5RequestParamSort<T> = `${Exclude<keyof T, symbol>}${':asc' | ':desc' | ''}`
-
-type Strapi5RequestParamPopulate<T> = {
-  [K in keyof T]: T[K] extends object
-    ? T[K] extends Array<infer I>
-      ? `${Exclude<K, symbol>}` | `${Exclude<K, symbol>}.${Strapi5RequestParamPopulate<I>}`
-      : `${Exclude<K, symbol>}` | `${Exclude<K, symbol>}.${Strapi5RequestParamPopulate<T[K]>}`
-    : never;
-}[keyof T]
-
 export interface Strapi5RequestParams<T> {
-  fields?: Array<Strapi5RequestParamField<T>>
-  populate?: '*' | Strapi5RequestParamPopulate<T> | Array<Strapi5RequestParamPopulate<T>>
-  sort?: Strapi5RequestParamSort<T> | Array<Strapi5RequestParamSort<T>>
+  fields?: Array<StrapiRequestParamField<T>>
+  populate?: '*' | StrapiRequestParamPopulate<T> | Array<StrapiRequestParamPopulate<T>>
+  sort?: StrapiRequestParamSort<T> | Array<StrapiRequestParamSort<T>>
   pagination?: PaginationByOffset | PaginationByPage
   filters?: Record<string, unknown>
   publicationState?: 'live' | 'preview'

From 80fb74324af02a6987239cf630184cf57d7534c6 Mon Sep 17 00:00:00 2001
From: Christophe Carvalho Vilas-Boas <christophe.carvalhovilasboas@gmail.com>
Date: Sun, 24 Nov 2024 23:41:16 +0100
Subject: [PATCH 5/5] docs(types): Strapi v5 types for Fields param

---
 playground/pages/index.vue | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/playground/pages/index.vue b/playground/pages/index.vue
index d3e39a9d..2c798846 100644
--- a/playground/pages/index.vue
+++ b/playground/pages/index.vue
@@ -7,6 +7,20 @@
     <h2>Version</h2>
     <pre>{{ version }}</pre>
 
+    <h2>API</h2>
+    <button
+      type="button"
+      @click="getCollections"
+    >
+      Get collections
+    </button>
+    <button
+      type="button"
+      @click="getUntyped"
+    >
+      Get untyped
+    </button>
+
     <div v-if="user">
       <h2>User</h2>
       <button
@@ -73,7 +87,6 @@ type Collection = {
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 const getCollections = () => {
   return strapi.find<Collection>('collection', {
     fields: ['firstname'],
@@ -82,7 +95,6 @@ const getCollections = () => {
   })
 }
 
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 const getUntyped = () => {
   return strapi.find('untyped', {
     sort: ['random'],