Feat/volume groups #305
Feat/volume groups #305
Conversation
…lume_groups # Conflicts: # plugins/module_utils/prism/volume_groups.py
# Conflicts: # meta/runtime.yml
…lume_groups # Conflicts: # plugins/module_utils/prism/iscsi_clients.py # plugins/modules/ntnx_volume_groups.py
…lume_groups # Conflicts: # plugins/modules/ntnx_volume_groups.py
|
|
||
| if module.check_mode: | ||
| result["response"] = spec | ||
| result["response"]["disks"] = module.params.get("disks") |
There was a problem hiding this comment.
disks, vms and clients in check mode can be ignored as module.params[] doesn't specifiy the spec we are using for creating them
There was a problem hiding this comment.
Create spec is different from module params for this entities
|
|
||
| result["detached_clients"] = detached_clients | ||
|
|
||
| def detach_vms(): |
There was a problem hiding this comment.
We can detach multiple VMs and iscsi clients in delete ops. If every single vm or iscsi detachment is independent operation then we need to handle case where detachments of all entities should be attempted and should fail at last incase some ops on some entities fail in between. Suppose 1 VM detachment fails in between then we can error out after ops on all VMs have been done.
| @staticmethod | ||
| def _build_spec_vdisk(module, payload, vdisk): | ||
|
|
||
| disk_size_bytes = vdisk["size_gb"] * 1024 * 1024 * 1024 |
There was a problem hiding this comment.
Can create a convert func in utils which can be used by other modules as well
…lume_groups # Conflicts: # plugins/module_utils/prism/vdisks.py
# Conflicts: # meta/runtime.yml
No description provided.