Imprv/389 #413
Open
Imprv/389 #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhati-pradeep
requested changes
Oct 25, 2023
| - Absolute file path to the script. | ||
| type: path | ||
| required: true | ||
| suboptions: |
There was a problem hiding this comment.
suboptions is already defined above.
| @@ -355,14 +355,17 @@ def _build_spec_boot_config(self, payload, param): | |||
| return payload, None | |||
|
|
|||
| def _build_spec_gc(self, payload, param): | |||
| fpath = param["script_path"] | |||
| if param["script_path"]: | |||
There was a problem hiding this comment.
what if script path is not given?
Suggested change
| if param["script_path"]: | |
| if param.get("script_path"): |
| with open(fpath, "rb") as f: | ||
| content = base64.b64encode(f.read()) | ||
| else: | ||
| content = base64.b64encode(param["script"]) |
There was a problem hiding this comment.
param of b64encode function should be a bytes-like object
Suggested change
| content = base64.b64encode(param["script"]) | |
| content = base64.b64encode(param["script"].encode('ascii')) |
|
@grdavies Please add tests for your change. @alaa-bish can guide you here. |
|
@grdavies Can you please look into the PR comments in order to make it to release. |
abhinavbansal29
changed the base branch from
release/1.9.1
to
release/1.9.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to provide sysprep/cloud-init via variable instead of just an input script