Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imprv] Make changes to include vm name and categories mapping in resources #274

Closed
Gevorg-Khachatryan-97 opened this issue Sep 15, 2022 · 4 comments · Fixed by #405
Closed
Assignees
Labels
feature triage Tickets for triage

Comments

@Gevorg-Khachatryan-97
Copy link
Collaborator

Gevorg-Khachatryan-97 commented Sep 15, 2022

Make changes in ntnx_prism_vm_inventory.py to include vm name and categories mapping from "metadata" in vm information and set variable to have ability use those values to create groups.

self.inventory.set_variable(vm_name, key, value)

@bhati-pradeep
Copy link
Collaborator

Usecase:
Can create custom groups based on category and vm name (expressions) using constructed inventory feature : #235

@bhati-pradeep
Copy link
Collaborator

As v1.7 is approaching, moving this out of it and will consider it in next release

@bhati-pradeep bhati-pradeep added 1.9.0 Bug fixes and improvements triage Tickets for triage and removed 1.9.0 Bug fixes and improvements labels Mar 3, 2023
@bhati-pradeep bhati-pradeep changed the title [Feat] Make changes to include vm name and categories mapping in resources [Imprv] Make changes to include vm name and categories mapping in resources Aug 18, 2023
@bhati-pradeep
Copy link
Collaborator

#405 This will add categories mapping in inventory

@bhati-pradeep bhati-pradeep linked a pull request Oct 30, 2023 that will close this issue
@bhati-pradeep bhati-pradeep added the 1.9.3_triage Bug fixes & Improvements label Aug 5, 2024
@bhati-pradeep bhati-pradeep self-assigned this Sep 18, 2024
@george-ghawali george-ghawali removed the 1.9.3_triage Bug fixes & Improvements label Oct 9, 2024
@george-ghawali
Copy link
Collaborator

This issue is resolved and closed. The fix has been merged via the PR linked in this issue. VM names and categories are now handled correctly, and groups can be created as expected. Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature triage Tickets for triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants