Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An already marked project gets marked again when I use mp command #4652

Open
nus-pe-bot opened this issue Apr 14, 2023 · 1 comment
Open

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Apr 14, 2023

When I mark a project, this message pops up, which is correct -
Marked Project: Sky Painting, due by: Apr 14 2023 14:13 PM, Price: $3.00; Tags: [painting] [commission]

However, if I mark this same project again, then this same error message comes again, which I feel could be changed to something I like "This project is already marked" or something on these lines to avoid confusion.

Relevant screenshot -

image.png

Steps to reproduce -

  1. Input mp 1
  2. Marked Project: Sky Painting, due by: Apr 14 2023 14:13 PM, Price: $3.00; Tags: [painting] [commission] will be displayed correctly.
  3. Input mp 1 again

[original: nus-cs2103-AY2223S2/pe-interim#4643] [original labels: severity.Low type.FunctionalityBug]
@zrei
Copy link

zrei commented Apr 17, 2023

Team's Response

This is the expected behaviour of the mark command, the change stated here would be an improvement to the existing feature, so the issue is a feature flaw instead.

While it may be clearer to inform the user that the project is already marked as done, functionally it changes nothing as the status of the project doesn't change. There were other functionalities that we worked on instead.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants