This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
Sounds #112
Open
Sounds #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember some Google Summer of Code student messaging me on IRC saying that they implemented sound notifications, but I never got a PR from them, huh |
Yes, by installer, when we get one sorted out, which is a whole different issue. Also, we need to do something about coding style, you are completely ignoring mine : ) |
|
Anyway, it will take me some time to go over this and messages pull requests since it seems that I will be very busy for the next two weeks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have sounds in our repo for a long time, but nobody used them, till now.
I implemented the sounds as soundpacks (themes), so the sounds from our sound directory are a "default pack" and have to moved into the soundpack directory (by installer?):
QStandardPaths::writableLocation(QStandardPaths::ConfigLocation) + '/' + AppInfo::name + "/sounds"I did the pack handling different from the smileypacks, if it's better in this way, I'll change the smileypack, too.