Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding for translated text in top-page cards #417

Closed
melissawm opened this issue Apr 19, 2021 · 9 comments · Fixed by #432
Closed

Padding for translated text in top-page cards #417

melissawm opened this issue Apr 19, 2021 · 9 comments · Fixed by #432

Comments

@melissawm
Copy link
Member

Similar to #416: translated (portuguese) text in the cards takes up more space than expected. Row 1, column 2 shows the text too close to the bottom border:

Screenshot_20210419_182250

Not sure if this will happen for other languages, though.

@rgommers
Copy link
Member

I'm not sure if there's a better solution than "use as much whitespace as the most verbose language needs". @joelachance any other ideas?

@joelachance
Copy link
Collaborator

text-overflow: ellipsis; looks like a pretty cool solution that might be a good option here, I can look at this if needed. Let me know, @rgommers!

More examples/info here: https://css-tricks.com/snippets/css/truncate-string-with-ellipsis/

@rgommers
Copy link
Member

Great idea @joelachance! I think for box titles it may look a little odd and we should increase the space a bit to make things fit (if every 3-4 word title has the last word replaced by ... that probably loses too much), but for text that's 3-4 lines long it should work well. There's more multi-line examples at https://css-tricks.com/line-clampin/. The "fade out way" looks nice too.

@joelachance
Copy link
Collaborator

@rgommers, I agree about the titles, we should definitely increase padding/margin there. I also like the fade out for the main content in these cells, good find!
I can work on this one.

@joelachance joelachance self-assigned this Apr 21, 2021
@rgommers
Copy link
Member

Thanks!

@joelachance
Copy link
Collaborator

How does this look? I didn't add much to the title, but I think it looks a little better. I did check it on English and it seems fine, I didn't check it on other translations yet besides en and pt.

Fade added, see column 2, row 1.

Screen Shot 2021-05-02 at 10 01 27 PM

@rgommers
Copy link
Member

rgommers commented May 3, 2021

Looks good to me! @melissawm what do you think?

PR preview will show en/pt/ja so it'll be easy to compare.

@joelachance
Copy link
Collaborator

PR above!
@rgommers @melissawm

@melissawm
Copy link
Member Author

Left my review in the PR - looks great to me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants