Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Text Visibility in DISC Logo Design #149

Open
hellosamyak opened this issue Jan 11, 2025 · 4 comments · May be fixed by #159
Open

Improve Text Visibility in DISC Logo Design #149

hellosamyak opened this issue Jan 11, 2025 · 4 comments · May be fixed by #159
Assignees
Labels
🎨 design design related

Comments

@hellosamyak
Copy link

hellosamyak commented Jan 11, 2025

The DISC logo design has visibility issues specifically in dark mode:

Contrast Issue:
The black text ("DISC" and the tagline) blends into the dark background in dark mode, making it difficult to read. Increasing the contrast by using a lighter color (e.g., white or light gray) would greatly improve visibility.

Font Size and Weight:
The tagline text is small and less legible, particularly in dark mode. Slightly increasing the font size and weight could enhance readability.

Potential Enhancements:
-Adding a text shadow or glow effect could further improve text visibility against the dark background.
-Placing the text over a solid or semi-transparent background could separate it more clearly from the design elements.

Suggested Changes:

  1. Update the text color for dark mode to a lighter shade (e.g., white or light gray) for higher contrast.
  2. Slightly increase the font size and weight of the tagline text for better legibility.
  3. Consider adding a subtle text shadow or glow effect for emphasis in dark mode.

Attachments:
Screenshot 2025-01-11 184703

Steps to Reproduce:

  1. Switch to dark mode in the application or website where the logo is used.
  2. Observe the visibility of the text ("DISC" and tagline) against the dark background.
@aterrel aterrel added the 🎨 design design related label Jan 11, 2025
@riteshdavv
Copy link

Hi! I'd like to work on this issue. Could you please assign it to me?

My approach will include: (as been given above)

  • Updating the text color for dark mode to a lighter shade for better contrast.
  • Adjusting the font size and weight of the tagline for improved readability.
  • Adding a subtle text shadow or glow effect for emphasis in dark mode.

Thank you!

@aterrel
Copy link
Member

aterrel commented Jan 12, 2025

Sounds great! I've assigned to ritshdavv. FYI, I don't know how we want to tackle approving design changes just yet. Let's make the change and I can pester folks on @numfocus/disc-committee on this as we see some ideas come to fuition.

@riteshdavv
Copy link

Thank you for assigning this to me! @aterrel

I just submitted a PR with the proposed changes, including the alternate solution, and added screenshots for both light and dark modes to assist with the review. I'll wait for the feedback from the @numfocus/disc-committee to see how they'd like to proceed.

Let me know if there's anything else you'd like me to address!

@riteshdavv
Copy link

Subject: Update on PR

I’m working on the changes, but I had to delete the head repository attached to the PR due to alignment with new workflow. I’ll resolve the issue with an alternate solution and submit a new PR soon.

Thank you for your understanding!

@riteshdavv riteshdavv linked a pull request Jan 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 design design related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants