Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolution Mismatch #34

Open
HakkaTjakka opened this issue Sep 5, 2022 · 4 comments
Open

Resolution Mismatch #34

HakkaTjakka opened this issue Sep 5, 2022 · 4 comments

Comments

@HakkaTjakka
Copy link

Hello Sir,

I'm working with this repo and i'm stuck on the following:

If i use input-resolutions with dar 16:9 on 1920x1080 or below like 1280x720 or 640x360 the pipglshader works fine.
But if i have other resolutions the texture(s) is/are screwed up.

I've put a sample into my repo on: SAMPLE

I've looked into the source and tried some stuff but i can't get it right.

I've patched FFmpeg-n4.3.1 with your code. (SOURCES)

I would like to use different (full) resolutions that i can use in the GPU shaders so i can zoom in on them....
Maybe you got a fix?

Thanks for reading, have a nice day.
Gerard W.

@numberwolf
Copy link
Owner

If i use input-resolutions with dar 16:9 on 1920x1080 or below like 1280x720 or 640x360 the pipglshader works fine.
But if i have other resolutions the texture(s) is/are screwed up.

Resolution:

If your render-window's aspect ratio is not match video's aspect ration, you should scale the video's aspect same sa windows's aspect; last, after render, scale it back to your target~

@LL020202
Copy link

If i use input-resolutions with dar 16:9 on 1920x1080 or below like 1280x720 or 640x360 the pipglshader works fine.
But if i have other resolutions the texture(s) is/are screwed up.

Resolution:

If your render-window's aspect ratio is not match video's aspect ration, you should scale the video's aspect same sa windows's aspect; last, after render, scale it back to your target~

What should I do when using vertical video?
Currently, it can support 16:9 on 1920x1080, but if it is 9:16 on 1080x1920?
thanks

@YeautyYE
Copy link

What should I do when using vertical video? Currently, it can support 16:9 on 1920x1080, but if it is 9:16 on 1080x1920? thanks

I have the same question.
Also, what if the original video resolution is higher than the screen? Is there a simple demo that we can learn about

@YeautyYE
Copy link

If i use input-resolutions with dar 16:9 on 1920x1080 or below like 1280x720 or 640x360 the pipglshader works fine.
But if i have other resolutions the texture(s) is/are screwed up.

Resolution:

If your render-window's aspect ratio is not match video's aspect ration, you should scale the video's aspect same sa windows's aspect; last, after render, scale it back to your target~

What is the reason? Can you provide an idea for us to modify the source code to solve the problem? Because scaling video can lead to quality loss and performance loss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants