Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove ByteFlow and FlowInfo classes. #75

Open
Tracked by #72
kc611 opened this issue Jun 21, 2023 · 1 comment · May be fixed by #84
Open
Tracked by #72

Refactor: Remove ByteFlow and FlowInfo classes. #75

kc611 opened this issue Jun 21, 2023 · 1 comment · May be fixed by #84

Comments

@kc611
Copy link
Contributor

kc611 commented Jun 21, 2023

As titled,

The ByteFlow and FlowInfo classes can be removed to reduce complexity. All of the methods of the classes can either be made part of the SCFG object or can be made into a function rather than a part of the class.

@kc611 kc611 mentioned this issue Jun 19, 2023
6 tasks
@esc
Copy link
Member

esc commented Jun 21, 2023

The additional bit is that the Python bytecode itself can be stored as metadata on the PythonByteCode blocks. This will allow those classes to be removed entirely.

I think that the ideal API would be:

scfg = SCFG.from_python_function(python_func)

Or:

scfg = SCFG(python_func)

Also, this means, the ByteFlowRenderer can be removed too because PythonBytecodeBlocks will have the bytecode embedded and as such contain all the information they need to supply to be rendered.

@esc esc changed the title Remove ByteFlow and FlowInfo classes. Refactor: Remove ByteFlow and FlowInfo classes. Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants