Target 0.44.0: Fix osx wheel build #1104
Open
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarkall
reviewed
Nov 27, 2024
|
To clarify my understanding - is the llvmdev conda package used on Windows and Linux, and only the manylinux one recipe used on macOS? |
gmarkall
approved these changes
Nov 27, 2024
|
RE: #1104 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target branch is
release0.44.Needs to be cherrypicked later to main
Summary:
zstddependency.Additionally, building of compiler-rt is turned off. The build machines do not have iOS SDK, the missing SDK is causing errors. The fix to not error-out due to iOS SDK is introduced in llvm 17 (llvm/llvm-project@78fb021)turned off iOS support and renabled compiler-rt in 135be02