Issue 118 catboost #119
Closed
Issue 118 catboost #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 94.81% 94.82% +<.01%
==========================================
Files 25 25
Lines 1582 1584 +2
Branches 220 220
==========================================
+ Hits 1500 1502 +2
Misses 49 49
Partials 33 33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Nice work!
I believe we need to test this new parameter, though. Probably, we could update this test to use the added parameter fit_params. Or even create another test.
|
I'm reviewing this test because it's breaking when I insert the |
caique-lima
previously approved these changes
Feb 3, 2020
|
Closing this one as we don't have updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Todo list
Background context
fitmethod. One possible solution is to add afit_paramsinto the CatBoost function in FkLearn for increased flexibility.This is important especially for CatBoost because the parameter that allows it to treat categorical features by itself is inside the
fitmethod, and this is the main differential in this library.Description of the changes proposed in the pull request
Allow the user to set fit params in CatBoost: https://catboost.ai/docs/concepts/python-reference_catboostregressor_fit.html#python-reference_catboostregressor_fit
Where should the reviewer start?
src/fklearn/training/classification.py
src/fklearn/training/regression.py