Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics for independent val loaders vs for val loaders split from training loader #2

Open
ntubiolin opened this issue Feb 17, 2020 · 0 comments

Comments

@ntubiolin
Copy link
Owner

  1. Why can't I have split val loaders with independent val loaders?
    What if I want to not only watch val accuracies but val loss...
    def _setup_valid_data_loaders(self):
    if 'valid_data_loaders' in global_config.keys():
    valid_data_loaders = self._setup_data_loaders('valid_data_loaders')
    if self.data_loader.validation_split > 0:
    raise ValueError(f'Split ratio should not > 0 when other validation loaders are specified.')
  2. Metric cannot tell whether the loader is correct.
    My metric for Validator cannot refuse to eat per-batch output when encounteringTrainer
    def _update_all_metrics(self, data_input, model_output, write=True):
    for metric in self.evaluation_metrics:
    with torch.no_grad():
    value = metric.update(data_input, model_output)
    # some metrics do not have per-batch evaluation (e.g. FID), then value would be None
    if write and value is not None:
    self.writer.add_scalar(metric.nickname, value)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant