Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant attribute [Was: class and className entries] #610

Open
dgwyer opened this issue Jan 20, 2022 · 1 comment
Open

Remove redundant attribute [Was: class and className entries] #610

dgwyer opened this issue Jan 20, 2022 · 1 comment
Labels
chores 🧹 Infrastructure and updates enhancement

Comments

@dgwyer
Copy link
Contributor

dgwyer commented Jan 20, 2022 •
edited
Loading

While inspecting some of the rendered SVG code I noticed that some group elements contain a mixture of class and className attributes. The className attribute appears to mirror the class attribute.

See this screenshot for an example:

image6

In the rendered markup should we be outputting a class attribute only?
@alexeyraspopov
Copy link
Member

In the rendered markup should we be outputting a class attribute only?

It should, good catch! At the very least class itself is still present which means there is no functional bug, but redundant attribute definitely worth removing.

@willingc willingc changed the title class and className entries Remove redundant attribute [Was: class and className entries] Jan 22, 2022
@willingc willingc added the chores 🧹 Infrastructure and updates label Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chores 🧹 Infrastructure and updates enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexeyraspopov @dgwyer @willingc