Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax highlighting on Markdown previews #4546

Merged
merged 3 commits into from
Sep 9, 2019
Merged

Fix syntax highlighting on Markdown previews #4546

merged 3 commits into from
Sep 9, 2019

Conversation

captainsafia
Copy link
Member

@rgbkrk
Copy link
Member

rgbkrk commented Sep 3, 2019

The error in CI looks like the tsconfig and/or the package.json need to be updated within the markdown package to include the presentational components.

BenRussert
BenRussert approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@BenRussert BenRussert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@BenRussert BenRussert merged commit 7d722cb into master Sep 9, 2019
@rgbkrk rgbkrk deleted the safia/fix-markdown-rendering branch September 18, 2019 22:20
@lock lock bot added the outdated workflow: issue should stay closed label Dec 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BenRussert BenRussert BenRussert approved these changes

@rgbkrk rgbkrk Awaiting requested review from rgbkrk

Assignees
No one assigned
Labels
outdated workflow: issue should stay closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax highlighting works in rendered markdown not respecting theme
3 participants
@captainsafia @rgbkrk @BenRussert