Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Explorer: Reduce package size #15

Open
stormpython opened this issue Feb 11, 2019 · 6 comments
Open

Data Explorer: Reduce package size #15

stormpython opened this issue Feb 11, 2019 · 6 comments
Assignees
Labels
chore Chore or quality of life improvement help wanted Extra attention is needed

Comments

@stormpython
Copy link
Member

Is your feature request related to a problem? Please describe.
The bundled size of Data Explorer is currently 1.5MB, which is too large to be a reasonable component pulled in by other libraries.

Describe the solution you'd like
Need to reduce the size of the package. Open to any suggestions for scoping the requirements down.

Describe alternatives you've considered

@stormpython
Copy link
Member Author

@emeeks I opened this issue for reducing the package size. Feel free to add your comments or possible solutions.

@BenRussert
Copy link
Member

Looks like there are some unused deps like lodash in the package.json if that helps.

https://github.com/nteract/nteract/blob/master/packages/data-explorer/package.json#L30

@rgbkrk
Copy link
Member

rgbkrk commented Feb 12, 2019

Probably won't affect the webpack bundle, but styled-jsx can be deleted too. Those should be taken out anyways.

@hydrosquall
Copy link
Member

hydrosquall commented Apr 26, 2019

Similarly, react-hot-loader also appears to be unused, although its less than a 1 KB so it won't help much.

Semiotic itself takes the majority of the weight, as seen here - it suggests the bundle is currently 1.1 MB if minified.

This treemap could probably help with determining a bundle optimization strategy.

(interactive source: https://bundlephobia.com/result?p=@nteract/[email protected] )

@stale
Copy link

stale bot commented Feb 20, 2020

This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed.
It's more than likely that just by me posting about this, the maintainers will take a closer look at these long forgotten issues to help evaluate what to do next.
If you would like to see this issue get prioritized over others, there are multiple avenues 🗓:

  • Ask how you can help with this issue 👩🏿‍💻👨🏻‍💻
  • Help solve other issues the team is currently working on 👨🏾‍💻👩🏼‍💻
  • Donate to nteract so we can support developers to work on these features and bugs more regularly 💰🕐

Thank you!

@stale stale bot closed this as completed Mar 22, 2020
@captainsafia
Copy link
Member

@emeeks Reopening and transferring this to the data explorer repo.

@captainsafia captainsafia reopened this Mar 22, 2020
@captainsafia captainsafia transferred this issue from nteract/nteract Mar 22, 2020
@willingc willingc added chore Chore or quality of life improvement help wanted Extra attention is needed labels Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore or quality of life improvement help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants