Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "id" back to NotebookSession class #135

Open
mpacer opened this issue Jun 15, 2019 · 0 comments
Open

Add "id" back to NotebookSession class #135

mpacer opened this issue Jun 15, 2019 · 0 comments

Comments

@mpacer
Copy link
Member

mpacer commented Jun 15, 2019

Currently we are consuming the id passed through via the sessions response http://jupyter-api.surge.sh/#!/sessions/get_api_sessions_session in the nb_client library and not setting it to a variable. My guess is that this was removed earlier because of similar issues to those raised around keeping the kernel's "id" field.

I discovered this as I was writing unit tests for the client section; I am going to refrain from adding it in those tests, but will leave commented code in place to indicate the functionality's future return (mostly for the sake of future integration tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant