Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that finish is called in async RequestHandler tests #133

Open
mpacer opened this issue Jun 11, 2019 · 0 comments
Open

Ensure that finish is called in async RequestHandler tests #133

mpacer opened this issue Jun 11, 2019 · 0 comments

Comments

@mpacer
Copy link
Member

mpacer commented Jun 11, 2019

This issue arose as part of #130, specifically as I discovered that we were running into a new set of errors when testing a method on a synchronous handler.

Some of the comments I added relate, but it comes down to needing to await those methods

await handler.get() where it is currently handler.get().

This is especially important for success tests.

The issue that comes up has to do with whether self._transforms has been set by the application or not by the time self.flush() is called. Given that the Application is a mock application and isn't calling a handler delegate this seems to not be set by default in our current mock framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant