Make gold standards plural in config

ntalluri · Aug 23, 2024 · 522e66c · 522e66c
1 parent c30e7ed
commit 522e66c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/config/config.yaml b/config/config.yaml
@@ -117,7 +117,7 @@ datasets:
       # Relative path from the spras directory
       data_dir: "input"
 
-gold_standard:
+gold_standards:
     -
       # Labels can only contain letters, numbers, or underscores
       label: gs0

diff --git a/spras/config.py b/spras/config.py
@@ -152,7 +152,7 @@ def process_config(self, raw_config):
 
         # parse gold standard information
         try:
-            self.gold_standards = {gold_standard["label"]: dict(gold_standard) for gold_standard in raw_config["gold_standard"]}
+            self.gold_standards = {gold_standard["label"]: dict(gold_standard) for gold_standard in raw_config["gold_standards"]}
         except:
             self.gold_standards = {}
 

diff --git a/test/test_config.py b/test/test_config.py
@@ -20,7 +20,7 @@ def get_test_config():
             }
         },
         "datasets": [{"label": "alg1"}, {"label": "alg2"}],
-        "gold_standard": [{"label": "gs1", "dataset_labels": []}],
+        "gold_standards": [{"label": "gs1", "dataset_labels": []}],
         "algorithms": [{"params": ["param2", "param2"]}],
         "analysis": {
             "summary": {
@@ -120,7 +120,6 @@ def test_error_dataset_label(self):
 
     def test_correct_dataset_label(self):
         test_config = get_test_config()
-        print(test_config)
         correct_test_dicts = [{"label": "test"},  {"label": "123"}, {"label": "test123"}, {"label": "123test"}, {"label": "_"},
                               {"label": "test_test"}, {"label": "_test"}, {"label": "test_"}]
 
@@ -133,13 +132,13 @@ def test_error_gs_label(self):
         error_labels = ["test$", "@test'"]
 
         for test_label in error_labels:
-            test_config["gold_standard"][0]["label"] = test_label
+            test_config["gold_standards"][0]["label"] = test_label
             with pytest.raises(ValueError):  # raises error if any chars other than letters, numbers, or underscores are in gs label
                 config.init_global(test_config)
 
     def test_error_gs_dataset_mismatch(self):
         test_config = get_test_config()
-        test_config["gold_standard"] = [{"label": "gs1", "dataset_labels": ["mismatch"]}]
+        test_config["gold_standards"] = [{"label": "gs1", "dataset_labels": ["mismatch"]}]
 
         with pytest.raises(ValueError):
             config.init_global(test_config)