Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing implementation on Android? No events. #27

Open
ad-proximate opened this issue Aug 13, 2024 · 0 comments
Open

Missing implementation on Android? No events. #27

ad-proximate opened this issue Aug 13, 2024 · 0 comments

Comments

@ad-proximate
Copy link

Hi all,

We don't get any events on Android.
We've deployed the demo app you're providing. It apparently runs, but we can't catch the events on Android instead of iOS.
It looks events don't get emitted.
How do you cop with it?

Moreover I've just realized that not all the functions are implemented for android.
I mean the index.d.ts includes this:

export declare class CoachMarks {
    static APP_SETTINGS_KEY: string;
    static DEBUG: boolean;
    static CONTINUE_LOCATIONS: ICONTINUE_LOCATION;
    events: Observable;
    private _willNavigateEvent;
    private _navigateEvent;
    private _clickEvent;
    private _cleanupEvent;
    static start(marks: Array<CoachMark>, options?: ICoachMarkOptions, instance?: CoachMarks): void;
    static HAS_SHOWN(): boolean;
    static PERSIST(): void;
    static RESET(): void;
    initEvents(): void;
    coachMarksViewWillNavigateToIndex(coachMarks: any, index: number): void;
    coachMarksViewDidNavigateToIndex(coachMarks: any, index: number): void;
    coachMarksViewDidClickedAtIndex(coachMarks: any, index: number): void;
    coachMarksViewDidCleanup(coachMarks: any): void;
}

index.ios.ts includes:

static PERSIST() {
    if (!CoachMarks.HAS_SHOWN()) {
      // Don't show again
      ApplicationSettings.setBoolean(CoachMarks.APP_SETTINGS_KEY, true);
    }
  }

  static RESET() {
    ApplicationSettings.setBoolean(CoachMarks.APP_SETTINGS_KEY, false);
  }

But index.android.ts doesn't includes those functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant