-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repository maintenance #164
Comments
I've got a fork over at https://github.com/ananthb/mikrotik-exporter mainly because I need arm container images. Time permitting, I'm planning on maintaining my fork too. Still open to working with @nshttpd though. |
@ananthb If you plan to maintain your fork, it would be good to clarify how to open PR and issue. I am still interested to add a testcontainer-go coverage for this project along with CI to make it easier to do maintenance (updating dependencies) and make it easier to accept new PR by having a good code coverage and tests against a real mikrotik service as much as possible. |
You can now create issues @Bluebugs. I've added basic automation on GitHub Actions already. I'd love to extend that with comprehensive tests. |
There hasn't been much activity in the past 2 years. I can see that one difficulty in accepting pr is that there is no tests. Will it help unlock this if integration tests using testcontainer-go and docker routeros image where provided along with github action and coverage report?
The text was updated successfully, but these errors were encountered: