Save IP of autopower client in DB

[UsualSpec]

Somewhat related: why do we send a request to the client in order to get the IP? Why not simply save the IP in the database when the client registers to the server? Sounds like it would be a lot simpler, no?

And if the IP changes, the client would anyway register again to the server I suppose, since changing IP address (almost always) implies we lost network connectivity. Or am I missing something?

Originally posted by @romain-jacob in #24 (comment)

[UsualSpec]

The main reason was that saving the IP in the DB is redundant and could become outdated.
Therefore the IP address attributes (along with others) was removed from the schema in a7f7e48

We decided that getting the IP directly from the device in the UI would be a better choice as it's always up to date.

[UsualSpec]

It would be possible to retrieve the IP like in

autopower/server/server.py

Lines 359 to 363 in 1911af7

	# if we get back a ping message, overwrite content with ip/peer of client
	if resp.msgType == pbdef.api__pb2.clientResponseType.INTRODUCE_CLIENT:
	# get ip address only (see https://stackoverflow.com/a/21908815)
	ipPort = ulunquote(context.peer())[5:] # remove ipv4/ipv6 prefix
	ip, sep, _ = ipPort.rpartition(":")

Then save the IP e.g. in

autopower/server/server.py

Line 338 in 1911af7

def registerClient(self, request, context):

[romain-jacob]

I'm not entirely sure what would happen to the gRPC connection if the client IP changes. Would it survive the change? Because if not, then I don't see why would need to collect the IP in a server request; we can just get it when the client registers, as it would need to re-register if the IP changes.

... unless, in some magical way I don't understand, the gRPC connection survives the client getting a new IP?

[UsualSpec]

I believe that currently a client side change would mean that a new connection gets established.
However, if gRPC uses QUIC/HTTP3 in future I could imagine that the connection stays active (QUIC connection migration; https://www.rfc-editor.org/rfc/rfc9000.html#section-5-4). See also https://kmcd.dev/posts/grpc-over-http3/