Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In order for company-go to work with foreign packages, it requires a -source flag #529

Open
kat-co opened this issue Sep 25, 2018 · 1 comment

Comments

@kat-co
Copy link

kat-co commented Sep 25, 2018

Per mdempsky#32, a -source flag needs to be passed to this forked version of gocode in order for it to find references in foreign packages.

Since company-go in MELPA comes from this repo, it puts us in a strange position since nsf/gocode doesn't supports this flag. With Go's own Language Server Protocol server in development, the need for the gocode tool may "soon" be obviated. Have you considered splitting out the emacs packages into their own repos?

kat-co added a commit to kat-co/gocode that referenced this issue Sep 25, 2018
I also noticed that the forked gocode does not support `csv-with-package`, and so I changed this at the same time. I am increasingly unsure if this change should be merged, or if the version in MELPA should be repointed to the forked company-go.

Fixes nsf#529
@nsf
Copy link
Owner

nsf commented Sep 26, 2018

It wasn't added by me there: https://github.com/melpa/melpa/blob/master/recipes/company-go. If it wasn't added by me, then it probably can be changed by somebody else also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants