Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#877] Fix ACA-issued certificates not verifying in OpenSSL #878

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

iadgovuser59
Copy link
Collaborator

This PR addresses ACA-issued certificates (LDevID and AK) not verifying properly through OpenSSL against the ACA certificate chain. Below is a comprehensive list of changes:

  • Changes the AKID on signed certs from the EK to the ACA CA chain
  • Removes critical marking from AKI, in conformance with RFC 5280 section 4.2.1.1
  • Added missing extensions in the generated certificate, including the signing extension (keyEncipherment | digitalSignature) and basic constraints
  • Signs the issued certificates with the leaf CA3 key instead of the portal/TLS key
  • Updates unit tests (AttestationCertificateAuthorityTest.java)
  • Fixes a regression where AK and LDevID keys are not marked properly on the Issued Certificates page (likely caused by Jackson handling of isLDevID, related to beginning with the word is; renamed to ldevID)

Closes #877.

@iadgovuser59 iadgovuser59 self-assigned this Nov 19, 2024
@iadgovuser59 iadgovuser59 added the bug Something isn't working label Nov 19, 2024
@iadgovuser26 iadgovuser26 merged commit accacbd into main Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ACA-issued certificates not verifying in OpenSSL
2 participants