Disable sbom on windows

nsacyber · Jan 30, 2024 · 1952b77 · 1952b77
1 parent dd9e4ef
commit 1952b77
Showing 1 changed file with 17 additions and 13 deletions.
diff --git a/.github/workflows/create_aca_images.yml b/.github/workflows/create_aca_images.yml
@@ -1,4 +1,4 @@
-name: ACA Docker Image Build
+name: Create ACA Docker Image
 on: 
   push:
   release:
@@ -82,8 +82,8 @@ jobs:
       uses: docker/build-push-action@v5
       with:
         context: ./.ci/docker
-        file: Dockerfile.$FILE
-        tags: $TAG
+        file: Dockerfile.${{env.FILE}}
+        tags: ${{env.TAG}}
         push: true
         sbom: true
 
@@ -97,8 +97,10 @@ jobs:
     - name: Checkout main
       uses: actions/checkout@v4
 
-    - name: Set up Docker Buildx
-      uses: docker/setup-buildx-action@v3
+#   Leaving this in case we want to check if docker's sbom option below still attempts to use privileged mode in the future
+#   There are third party options, but requires sending password through those actions.
+#    - name: Set up Docker Buildx
+#      uses: docker/setup-buildx-action@v3
 
     - name: Login to GitHub Container Registry
       uses: docker/login-action@v3
@@ -111,10 +113,10 @@ jobs:
       uses: docker/build-push-action@v5
       with:
         context: ./.ci/docker
-        file: Dockerfile.$FILE
-        tags: $TAG
+        file: Dockerfile.${{env.FILE}}
+        tags: ${{env.TAG}}
         push: true
-        sbom: true
+        # sbom: true  # Buildx on Windows requires privileged mode, and docker's action tries to use privileged mode
 
   windows-compat-image: # This job uses a different build arg than the other windows job.
     needs: setup
@@ -126,8 +128,10 @@ jobs:
     - name: Checkout main
       uses: actions/checkout@v4
 
-    - name: Set up Docker Buildx
-      uses: docker/setup-buildx-action@v3
+#   Leaving this in case we want to check if docker's sbom option below still attempts to use privileged mode in the future
+#   There are third party options, but requires sending password through those actions.
+#    - name: Set up Docker Buildx
+#      uses: docker/setup-buildx-action@v3
 
     - name: Login to GitHub Container Registry
       uses: docker/login-action@v3
@@ -140,11 +144,11 @@ jobs:
       uses: docker/build-push-action@v5
       with:
         context: ./.ci/docker
-        file: Dockerfile.$FILE
-        tags: $TAG
+        file: Dockerfile.${{env.FILE}}
+        tags: ${{env.TAG}}
         build-args: BASE_IMAGE_TAG=lts-windowsservercore-1809
         push: true
-        sbom: true
+        # sbom: true  # Buildx on Windows requires privileged mode, and docker's action tries to use privileged mode
 
   manifest:
     needs: [rocky-image, windows-11-image, windows-compat-image]