Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of questions #223

Open
actaeon opened this issue Nov 4, 2023 · 0 comments
Open

A couple of questions #223

actaeon opened this issue Nov 4, 2023 · 0 comments

Comments

@actaeon
Copy link

actaeon commented Nov 4, 2023

Hi folks, thanks for the work on the client, it's appreciated.

Is this still accurate and / or relevant to this repo?

I ask because I really need to have the ability to pass in a context.Context to requests and I see #192 and #182 open for months without comment, tags or review. I'm willing to do whatever work is required to make this happen, but I don't want to go though the trouble if the PR will not be reviewed.

Also, it seems like make test is failing in the tip of v2 and also the v2.7.12 and v2.7.13 tags:

$make test

go fmt ./...
go vet ./...
# gopkg.in/ns1/ns1-go.v2/rest/model/dns_test
vet: rest/model/dns/example_test.go:57:46: not enough arguments in call to dns.NewRecord
	have (string, string, string)
	want (string, string, string, map[string]string, []string)
make: *** [test] Error 1

Is this still accurate?

I totally get that there may not be enough time or people to get to PRs, I'm not looking to pressure anybody. But if that's the case, I think maybe the docs need to change to reflect that?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant