From 12efe82d8fa0990a622e36f6a32f221457402d2f Mon Sep 17 00:00:00 2001 From: Vlad Date: Thu, 9 May 2024 04:49:10 +1100 Subject: [PATCH 1/2] chore(lru): use map.delete() directly The default implementation already returns boolean if the object has been deleted. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/delete#return_value --- internal/lrucache.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/internal/lrucache.js b/internal/lrucache.js index f4a97f2e..7cb095b7 100644 --- a/internal/lrucache.js +++ b/internal/lrucache.js @@ -17,12 +17,7 @@ class LRUCache { } delete (key) { - if (this.map.has(key)) { - this.map.delete(key) - return true - } else { - return false - } + return this.map.delete(key); } set (key, value) { From 9afd9e6954bc8582c8981ba0123d06f597433a75 Mon Sep 17 00:00:00 2001 From: Luke Karrys Date: Wed, 8 May 2024 14:17:58 -0700 Subject: [PATCH 2/2] Update internal/lrucache.js --- internal/lrucache.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/lrucache.js b/internal/lrucache.js index 7cb095b7..6d89ec94 100644 --- a/internal/lrucache.js +++ b/internal/lrucache.js @@ -17,7 +17,7 @@ class LRUCache { } delete (key) { - return this.map.delete(key); + return this.map.delete(key) } set (key, value) {