From f1c5ffcbdf08f20a6b5eda98b12b89a3ade209a5 Mon Sep 17 00:00:00 2001 From: btea <2356281422@qq.com> Date: Wed, 2 Oct 2024 17:46:26 +0800 Subject: [PATCH 1/2] fix: the information time object output by `npm view` should sorted by version --- lib/commands/view.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/commands/view.js b/lib/commands/view.js index cf7292a2f3b81..ac2f649164864 100644 --- a/lib/commands/view.js +++ b/lib/commands/view.js @@ -166,6 +166,15 @@ class View extends BaseCommand { log.info('view', `Ignoring invalid version: ${v}`) return false }).sort(semver.compareLoose) + const pckmntTime = {} + const invalidVersions = Object.keys(pckmnt.time).filter(v => !semver.valid(v)) + invalidVersions.forEach(v => { + pckmntTime[v] = pckmnt.time[v] + }) + pckmnt.versions.forEach(v => { + pckmntTime[v] = pckmnt.time[v] + }) + pckmnt.time = pckmntTime // remove readme unless we asked for it if (args.indexOf('readme') === -1) { From 3051329936644f74b883dd3e11736cb10b89ea5d Mon Sep 17 00:00:00 2001 From: btea <2356281422@qq.com> Date: Wed, 2 Oct 2024 22:41:10 +0800 Subject: [PATCH 2/2] fix: refactor --- lib/commands/view.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/commands/view.js b/lib/commands/view.js index ac2f649164864..a9f1c1a78730e 100644 --- a/lib/commands/view.js +++ b/lib/commands/view.js @@ -166,15 +166,7 @@ class View extends BaseCommand { log.info('view', `Ignoring invalid version: ${v}`) return false }).sort(semver.compareLoose) - const pckmntTime = {} - const invalidVersions = Object.keys(pckmnt.time).filter(v => !semver.valid(v)) - invalidVersions.forEach(v => { - pckmntTime[v] = pckmnt.time[v] - }) - pckmnt.versions.forEach(v => { - pckmntTime[v] = pckmnt.time[v] - }) - pckmnt.time = pckmntTime + pckmnt.time = Object.fromEntries(Object.entries(pckmnt.time).sort(semver.compare)) // remove readme unless we asked for it if (args.indexOf('readme') === -1) {