feat(framework): add class-validator support #6840
Conversation
👷 Deploy request for novu-stg-vite-dashboard-poc pending review.Visit the deploys page to approve it
|
paulwer
changed the title
|
@rifont i marked you to may review this PR, as you have created the original validator implementation. |
|
@paulwer Thanks for submitting this PR. It coincides with an internal conversation about allowing contributors to bring their own validations, such as Zod, ClassValidator, etc... Our dynamic require("x") pattern, along with peer dependencies, served us well so far, but as we moved our package to its ESM/CJS state, we noticed it caused some issues in some bundlers, such as Turbopack beta. We expect to conclude our strategy by the end of this week, and the decision might also affect this PR. We would love to hear your opinions or suggestions on the matter. |
|
Hi @SokratisVidros, thanks for the feedback. If the descision would be to only allow json-schema, i would like to encourage you to provide examples or mapper functions to be installed additionaly. If I can support this in any way, please let me know :) |
What changed? Why was the change needed?
Class Validator support for @novu/framework
Expand for optional sections
Related enterprise PR
Special notes for your reviewer
I was not able to resolve the preexisting type errors present at client.validation.test.ts. Those may have to be fixed and tested before merging.
Please also check the step.types.ts change in details.
closes #6682