Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Dependency needs updating due to use of VS 2022 Generator #549

Open
capnkenny opened this issue Jan 4, 2023 · 2 comments
Open

CMake Dependency needs updating due to use of VS 2022 Generator #549

capnkenny opened this issue Jan 4, 2023 · 2 comments
Assignees
Labels
bug Something isn't working cmake Tickets specifically relating to the cmake build system. documentation A documentation related PR or issue.

Comments

@capnkenny
Copy link
Member

Describe the issue:
When attempting to build NovelRT on Windows 10 or 11 with Visual Studio 2022 installed, CMake versions 3.19 and 3.20 will fail using the default settings with the following error: "CMake Error: Could not create named generator Visual Studio 17 2022"
This appears to occur when using Visual Studio Code, however it can happen with other IDEs if not using Ninja or Unix Makefiles by default.

Please provide the steps to reproduce if possible:

  1. Clone the repo
  2. Open Visual Studio Code (configured with CMake Tools / C++ Support enabled)
  3. Run the default configure command
  4. See error

Expected behaviour:
The CMake version dependency should be updated to 3.21 in readme, Wiki, and the root CMakeLists.txt.

Please tell us about your environment:

  • OS Version: Windows 11 22H2
    If building from source:
  • Compiler Version: Visual Studio 2022 v17.4.3
  • IDE: Visual Studio Code, C/C++ (Microsoft) extension installed
  • Git fork/branch URL: N/A, using main branch

Additional context:
It seems to be failing at the command level, before the CMakeLists.txt file is even processed.

@capnkenny capnkenny added bug Something isn't working cmake Tickets specifically relating to the cmake build system. documentation A documentation related PR or issue. labels Jan 4, 2023
@capnkenny capnkenny changed the title CMake Dependency needs updating due to use of VS Generator CMake Dependency needs updating due to use of VS 2022 Generator Jan 4, 2023
@RubyNova
Copy link
Member

RubyNova commented Jan 9, 2023

I'll deal with this.

@RubyNova RubyNova self-assigned this Jan 9, 2023
@capnkenny
Copy link
Member Author

Possibly out of date - currently, CI is using CMake 3.24 and our CMakeLists will throw a fatal error if it's not at least that, so we should probably update accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmake Tickets specifically relating to the cmake build system. documentation A documentation related PR or issue.
Projects
None yet
Development

No branches or pull requests

2 participants