Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Universal Binaries for macOS #545

Open
capnkenny opened this issue Dec 1, 2022 · 0 comments
Open

Introduce Universal Binaries for macOS #545

capnkenny opened this issue Dec 1, 2022 · 0 comments
Labels
cmake Tickets specifically relating to the cmake build system. good first issue Good for newcomers mac Tickets specifically related to MacOS. proposal A proposal up for debate.

Comments

@capnkenny
Copy link
Member

What is the current behaviour?
Currently, we only target Intel Apple machines and do not cross build for Apple Silicon.

What is the expected behaviour/change?
By setting a CMake flag, we should be able to specify CMake to produce universal binaries for both NovelRT and its dependencies for macOS systems, allowing compatibility on both Apple Silicon and Intel machines without a need to distribute separately.

What is the motivation / use case for changing the behavior?
Allowing for targeting both new and older Mac hardware.

Describe alternatives you've considered:
Distributing separately - would work, but would require cross-compilation efforts or would require interaction from a separate CI ring.

Are there any potential roadblocks or challenges facing this change?
Testing - we'd need an outside contributor with access to a macOS w/ Apple Silicon to test that a sample or the Engine Tests application produced with a Universal Binary is able to function on Apple Silicon (as a maintainer, I can test Apple w/ Intel).

Are there any downsides to implementing this change?
macOS binaries may bloat a little, but should not be much in theory.

Additional context
Stack Overflow explaining the change to make

@capnkenny capnkenny added good first issue Good for newcomers proposal A proposal up for debate. cmake Tickets specifically relating to the cmake build system. mac Tickets specifically related to MacOS. labels Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Tickets specifically relating to the cmake build system. good first issue Good for newcomers mac Tickets specifically related to MacOS. proposal A proposal up for debate.
Projects
None yet
Development

No branches or pull requests

1 participant