From e23dde5f7d8bd39d3ef0d8dc61a35b586fd8bc04 Mon Sep 17 00:00:00 2001 From: Dmitry Borodin Date: Wed, 31 Jan 2024 17:55:26 +0100 Subject: [PATCH 1/4] fix for release flow according issue discussion https://github.com/r0adkll/sign-android-release/issues/84 --- .github/workflows/android-release.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/android-release.yml b/.github/workflows/android-release.yml index d918a9b8ac..cda9f059b2 100644 --- a/.github/workflows/android-release.yml +++ b/.github/workflows/android-release.yml @@ -139,6 +139,8 @@ jobs: alias: ${{ secrets.ANDROID_KEYSTORE_KEY_ALIAS }} keyStorePassword: ${{ secrets.ANDROID_PLAY_STORE_KEYSTORE_PASSWORD }} keyPassword: ${{ secrets.ANDROID_PLAY_STORE_KEYSTORE_PASSWORD }} + env: + BUILD_TOOLS_VERSION: ${{ env.BUILD_TOOL_VERSION }} - name: Upload Gplay release APKs uses: actions/upload-artifact@v3 From dafac2c437961d7f3fc8996bfc438cb8d57f7c71 Mon Sep 17 00:00:00 2001 From: Dmitry Borodin Date: Wed, 31 Jan 2024 17:58:17 +0100 Subject: [PATCH 2/4] removed extra line --- .github/workflows/android-release.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/android-release.yml b/.github/workflows/android-release.yml index cda9f059b2..c876435878 100644 --- a/.github/workflows/android-release.yml +++ b/.github/workflows/android-release.yml @@ -158,4 +158,3 @@ jobs: track: internal - From 82280778136bd3e3f7dc5bd6f2080a16e22624a2 Mon Sep 17 00:00:00 2001 From: Dmitry Borodin Date: Wed, 31 Jan 2024 18:25:08 +0100 Subject: [PATCH 3/4] hardcoded build tools to 34 --- .github/workflows/android-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/android-release.yml b/.github/workflows/android-release.yml index c876435878..f3573ee57e 100644 --- a/.github/workflows/android-release.yml +++ b/.github/workflows/android-release.yml @@ -140,7 +140,7 @@ jobs: keyStorePassword: ${{ secrets.ANDROID_PLAY_STORE_KEYSTORE_PASSWORD }} keyPassword: ${{ secrets.ANDROID_PLAY_STORE_KEYSTORE_PASSWORD }} env: - BUILD_TOOLS_VERSION: ${{ env.BUILD_TOOL_VERSION }} + BUILD_TOOLS_VERSION: "34.0.0" - name: Upload Gplay release APKs uses: actions/upload-artifact@v3 From bc4759e9c4de7e1814ba52191802b2bb3dc988f5 Mon Sep 17 00:00:00 2001 From: Dmitry Borodin Date: Wed, 31 Jan 2024 19:01:31 +0100 Subject: [PATCH 4/4] created extra step to find out latest built tools for signing apk --- .github/workflows/android-release.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/android-release.yml b/.github/workflows/android-release.yml index f3573ee57e..5caac2416f 100644 --- a/.github/workflows/android-release.yml +++ b/.github/workflows/android-release.yml @@ -129,6 +129,13 @@ jobs: run: | ./gradlew clean assembleRelease --stacktrace + - name: Setup build tool version variable + shell: bash + run: | + BUILD_TOOL_VERSION=$(ls /usr/local/lib/android/sdk/build-tools/ | tail -n 1) + echo "BUILD_TOOL_VERSION=$BUILD_TOOL_VERSION" >> $GITHUB_ENV + echo Last build tool version is: $BUILD_TOOL_VERSION + - name: Sign app APK uses: r0adkll/sign-android-release@v1 # ID used to access action output @@ -140,7 +147,7 @@ jobs: keyStorePassword: ${{ secrets.ANDROID_PLAY_STORE_KEYSTORE_PASSWORD }} keyPassword: ${{ secrets.ANDROID_PLAY_STORE_KEYSTORE_PASSWORD }} env: - BUILD_TOOLS_VERSION: "34.0.0" + BUILD_TOOLS_VERSION: ${{ env.BUILD_TOOL_VERSION }} - name: Upload Gplay release APKs uses: actions/upload-artifact@v3