From e3221dfc666db03d64f30edb8f33c8c8cb035444 Mon Sep 17 00:00:00 2001 From: Danilo Pantani Date: Fri, 28 Jun 2024 20:37:49 +0200 Subject: [PATCH] refactor: remove deprecated `sdk.MustSortJSON` (#4219) * remove deprecated sort * add changelog --- changelog.md | 1 + ignite/templates/ibc/packet.go | 2 +- .../create/files/base/x/{{moduleName}}/module/module.go.plush | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/changelog.md b/changelog.md index 02f9d9493c..8c87a09713 100644 --- a/changelog.md +++ b/changelog.md @@ -79,6 +79,7 @@ - [#4086](https://github.com/ignite/cli/pull/4086) Retry to get the IBC balance if it fails the first time - [#4096](https://github.com/ignite/cli/pull/4096) Add new reserved names module and remove duplicated genesis order - [#4112](https://github.com/ignite/cli/pull/4112) Remove duplicate SetCmdClientContextHandler +- [#4219](https://github.com/ignite/cli/pull/4219) Remove deprecated `sdk.MustSortJSON` ## [`v28.3.0`](https://github.com/ignite/cli/releases/tag/v28.3.0) diff --git a/ignite/templates/ibc/packet.go b/ignite/templates/ibc/packet.go index ffa405df8d..85a9eb37eb 100644 --- a/ignite/templates/ibc/packet.go +++ b/ignite/templates/ibc/packet.go @@ -130,7 +130,7 @@ func moduleModify(replacer placeholder.Replacer, opts *PacketOptions) genny.RunF if err != nil { return channeltypes.NewErrorAcknowledgement(errorsmod.Wrap(sdkerrors.ErrJSONMarshal, err.Error())) } - ack = channeltypes.NewResultAcknowledgement(sdk.MustSortJSON(packetAckBytes)) + ack = channeltypes.NewResultAcknowledgement(packetAckBytes) } ctx.EventManager().EmitEvent( sdk.NewEvent( diff --git a/ignite/templates/module/create/files/base/x/{{moduleName}}/module/module.go.plush b/ignite/templates/module/create/files/base/x/{{moduleName}}/module/module.go.plush index a054e74c61..f39d646262 100644 --- a/ignite/templates/module/create/files/base/x/{{moduleName}}/module/module.go.plush +++ b/ignite/templates/module/create/files/base/x/{{moduleName}}/module/module.go.plush @@ -41,7 +41,7 @@ var ( _ appmodule.AppModule = (*AppModule)(nil) _ appmodule.HasBeginBlocker = (*AppModule)(nil) _ appmodule.HasEndBlocker = (*AppModule)(nil) - <%= if (isIBC) { %>_ porttypes.IBCModule = IBCModule{}<% } %> + <%= if (isIBC) { %>_ porttypes.IBCModule = (*IBCModule)(nil)<% } %> ) // ----------------------------------------------------------------------------